f864ef703e
I have to admit that I did very poor testing ind7307d8
and didn't notice that the "badfiles" plugin relies on mp3val (thanks to @devhell for packaging in6e1ef13
) and flac to be actually useful. We now patch in the store locations of these binaries and make "badfiles" an optional dependency (though enabled by default). Now, I have tested "beet bad" on my whole music collection and it worked fine (well, it has found errors... but that's what it is for). Signed-off-by: aszlig <aszlig@redmoonstudios.org>
182 lines
5.4 KiB
Nix
182 lines
5.4 KiB
Nix
{ stdenv, fetchFromGitHub, writeScript, glibcLocales
|
|
, buildPythonPackage, pythonPackages, python, imagemagick
|
|
|
|
, enableAcoustid ? true
|
|
, enableBadfiles ? true, flac ? null, mp3val ? null
|
|
, enableDiscogs ? true
|
|
, enableEchonest ? true
|
|
, enableFetchart ? true
|
|
, enableLastfm ? true
|
|
, enableMpd ? true
|
|
, enableReplaygain ? true
|
|
, enableThumbnails ? true
|
|
, enableWeb ? true
|
|
|
|
, bashInteractive, bashCompletion
|
|
}:
|
|
|
|
assert enableAcoustid -> pythonPackages.pyacoustid != null;
|
|
assert enableBadfiles -> flac != null && mp3val != null;
|
|
assert enableDiscogs -> pythonPackages.discogs_client != null;
|
|
assert enableEchonest -> pythonPackages.pyechonest != null;
|
|
assert enableFetchart -> pythonPackages.responses != null;
|
|
assert enableLastfm -> pythonPackages.pylast != null;
|
|
assert enableMpd -> pythonPackages.mpd != null;
|
|
assert enableReplaygain -> pythonPackages.audiotools != null;
|
|
assert enableThumbnails -> pythonPackages.pyxdg != null;
|
|
assert enableWeb -> pythonPackages.flask != null;
|
|
|
|
with stdenv.lib;
|
|
|
|
let
|
|
optionalPlugins = {
|
|
badfiles = enableBadfiles;
|
|
chroma = enableAcoustid;
|
|
discogs = enableDiscogs;
|
|
echonest = enableEchonest;
|
|
fetchart = enableFetchart;
|
|
lastgenre = enableLastfm;
|
|
lastimport = enableLastfm;
|
|
mpdstats = enableMpd;
|
|
mpdupdate = enableMpd;
|
|
replaygain = enableReplaygain;
|
|
thumbnails = enableThumbnails;
|
|
web = enableWeb;
|
|
};
|
|
|
|
pluginsWithoutDeps = [
|
|
"bench" "bpd" "bpm" "bucket" "convert" "cue" "duplicates" "embedart"
|
|
"filefilter" "freedesktop" "fromfilename" "ftintitle" "fuzzy" "ihate"
|
|
"importadded" "importfeeds" "info" "inline" "ipfs" "keyfinder" "lyrics"
|
|
"mbcollection" "mbsync" "metasync" "missing" "permissions" "play"
|
|
"plexupdate" "random" "rewrite" "scrub" "smartplaylist" "spotify" "the"
|
|
"types" "zero"
|
|
];
|
|
|
|
enabledOptionalPlugins = attrNames (filterAttrs (_: id) optionalPlugins);
|
|
|
|
allPlugins = pluginsWithoutDeps ++ attrNames optionalPlugins;
|
|
allEnabledPlugins = pluginsWithoutDeps ++ enabledOptionalPlugins;
|
|
|
|
testShell = "${bashInteractive}/bin/bash --norc";
|
|
completion = "${bashCompletion}/share/bash-completion/bash_completion";
|
|
|
|
in buildPythonPackage rec {
|
|
name = "beets-${version}";
|
|
version = "1.3.15";
|
|
namePrefix = "";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "sampsyo";
|
|
repo = "beets";
|
|
rev = "v${version}";
|
|
sha256 = "17mbkilqqkxxa8ra8b4zlsax712jb0nfkvcx9iyq9303rqwv5sx2";
|
|
};
|
|
|
|
propagatedBuildInputs = [
|
|
pythonPackages.enum34
|
|
pythonPackages.jellyfish
|
|
pythonPackages.munkres
|
|
pythonPackages.musicbrainzngs
|
|
pythonPackages.mutagen
|
|
pythonPackages.pathlib
|
|
pythonPackages.pyyaml
|
|
pythonPackages.unidecode
|
|
python.modules.sqlite3
|
|
python.modules.readline
|
|
] ++ optional enableAcoustid pythonPackages.pyacoustid
|
|
++ optional enableFetchart pythonPackages.requests2
|
|
++ optional enableDiscogs pythonPackages.discogs_client
|
|
++ optional enableEchonest pythonPackages.pyechonest
|
|
++ optional enableLastfm pythonPackages.pylast
|
|
++ optional enableMpd pythonPackages.mpd
|
|
++ optional enableReplaygain pythonPackages.audiotools
|
|
++ optional enableThumbnails pythonPackages.pyxdg
|
|
++ optional enableWeb pythonPackages.flask;
|
|
|
|
buildInputs = with pythonPackages; [
|
|
beautifulsoup4
|
|
imagemagick
|
|
mock
|
|
nose
|
|
rarfile
|
|
responses
|
|
];
|
|
|
|
patches = [
|
|
./replaygain-default-audiotools.patch
|
|
];
|
|
|
|
postPatch = ''
|
|
sed -i -e '/assertIn.*item.*path/d' test/test_info.py
|
|
echo echo completion tests passed > test/test_completion.sh
|
|
|
|
sed -i -e '/^BASH_COMPLETION_PATHS *=/,/^])$/ {
|
|
/^])$/i u"${completion}"
|
|
}' beets/ui/commands.py
|
|
'' + optionalString enableBadfiles ''
|
|
sed -i -e '/self\.run_command(\[/ {
|
|
s,"flac","${flac}/bin/flac",
|
|
s,"mp3val","${mp3val}/bin/mp3val",
|
|
}' beetsplug/badfiles.py
|
|
'';
|
|
|
|
doCheck = true;
|
|
|
|
preCheck = ''
|
|
(${concatMapStrings (s: "echo \"${s}\";") allPlugins}) \
|
|
| sort -u > plugins_defined
|
|
find beetsplug -mindepth 1 \
|
|
\! -path 'beetsplug/__init__.py' -a \
|
|
\( -name '*.py' -o -path 'beetsplug/*/__init__.py' \) -print \
|
|
| sed -n -re 's|^beetsplug/([^/.]+).*|\1|p' \
|
|
| sort -u > plugins_available
|
|
|
|
if ! mismatches="$(diff -y plugins_defined plugins_available)"; then
|
|
echo "The the list of defined plugins (left side) doesn't match" \
|
|
"the list of available plugins (right side):" >&2
|
|
echo "$mismatches" >&2
|
|
exit 1
|
|
fi
|
|
'';
|
|
|
|
checkPhase = ''
|
|
runHook preCheck
|
|
|
|
LANG=en_US.UTF-8 \
|
|
LOCALE_ARCHIVE=${assert stdenv.isLinux; glibcLocales}/lib/locale/locale-archive \
|
|
BEETS_TEST_SHELL="${testShell}" \
|
|
BASH_COMPLETION_SCRIPT="${completion}" \
|
|
HOME="$(mktemp -d)" \
|
|
nosetests -v
|
|
|
|
runHook postCheck
|
|
'';
|
|
|
|
doInstallCheck = true;
|
|
|
|
installCheckPhase = ''
|
|
runHook preInstallCheck
|
|
|
|
tmphome="$(mktemp -d)"
|
|
|
|
EDITOR="${writeScript "beetconfig.sh" ''
|
|
#!${stdenv.shell}
|
|
cat > "$1" <<CFG
|
|
plugins: ${concatStringsSep " " allEnabledPlugins}
|
|
CFG
|
|
''}" HOME="$tmphome" "$out/bin/beet" config -e
|
|
EDITOR=true HOME="$tmphome" "$out/bin/beet" config -e
|
|
|
|
runHook postInstallCheck
|
|
'';
|
|
|
|
meta = {
|
|
description = "Music tagger and library organizer";
|
|
homepage = http://beets.radbox.org;
|
|
license = licenses.mit;
|
|
maintainers = with maintainers; [ aszlig iElectric pjones ];
|
|
platforms = platforms.linux;
|
|
};
|
|
}
|