keybase: replace obsolete client

Fixes #17755.

As noted in the issue tracker, we have been carrying two versions of the
keybase client: the old node.js client and the new Go client. The old
client is unusable, but takes up the valuable `keybase` name. This
revision removes the old client entirely and replaces it with the new one.

pkgs/applications/misc/keybase/default.nix

@@ -1,37 +0,0 @@
-{ stdenv, fetchurl, makeWrapper, callPackage, gnupg, utillinux }:
-
-with stdenv.lib;
-
-let 
-  nodePackages = callPackage (import ../../../top-level/node-packages.nix) {
-    neededNatives = [] ++ optional (stdenv.isLinux) utillinux;
-    self = nodePackages;
-    generated = ./package.nix;
-  };
-
-in nodePackages.buildNodePackage rec {
-  name = "keybase-${version}";
-  version = "0.8.25";
-
-  src = [(fetchurl {
-    url = "https://github.com/keybase/node-client/archive/v${version}.tar.gz";
-    sha256 = "1zc357hwh26lsg8ngj7iwjdmywyzk6fz3wxmcqq1qyp2927i4jz3";
-  })];
-
-  deps = (filter (v: nixType v == "derivation") (attrValues nodePackages));
-  buildInputs = [ makeWrapper gnupg ];
-
-  postInstall = ''
-    wrapProgram "$out/bin/keybase" --set NODE_PATH "$out/lib/node_modules/keybase/node_modules/"
-  '';
-
-  passthru.names = ["keybase"];
-
-  meta = {
-    description = "CLI for keybase.io written in/for Node.js";
-    license = licenses.mit;
-    homepage = https://keybase.io/docs/command_line;
-    maintainers = with maintainers; [manveru];
-    platforms = platforms.linux;
-  };
-}

pkgs/top-level/aliases.nix

@@ -57,6 +57,7 @@ doNotDisplayTwice rec {
   inotifyTools = inotify-tools;
   joseki = apache-jena-fuseki; # added 2016-02-28
   jquery_ui = jquery-ui;  # added 2014-09-07
+  keybase-go = keybase;  # added 2016-08-24
   letsencrypt = certbot; # added 2016-05-16
   libdbusmenu_qt5 = qt5.libdbusmenu;  # added 2015-12-19
   libcap_manpages = libcap.doc; # added 2016-04-29

pkgs/top-level/all-packages.nix

@@ -2206,9 +2206,7 @@ in
 
   kexectools = callPackage ../os-specific/linux/kexectools { };
 
-  keybase = callPackage ../applications/misc/keybase { };
-
-  keybase-go = callPackage ../tools/security/keybase { };
+  keybase = callPackage ../tools/security/keybase { };
 
   kbfs = callPackage ../tools/security/kbfs { };