From b00bcf21abc392ecb1d93bd49f7a5ffbc8524ecf Mon Sep 17 00:00:00 2001 From: Mewp Date: Sat, 5 Jun 2021 10:35:20 +0200 Subject: [PATCH] nixos/acme: Remove an incorrect assertion from tests Commit 3a2e0c36e79cecaf196cbea23e75e74710140ea4 has removed `--reuse-key` from default renew options, yet the tests still expected keys not to change. This assertion is now removed, as they are supposed to change on each renew/change. --- nixos/tests/acme.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/nixos/tests/acme.nix b/nixos/tests/acme.nix index 6f98b0da378..fe8c4af3ea2 100644 --- a/nixos/tests/acme.nix +++ b/nixos/tests/acme.nix @@ -392,14 +392,11 @@ in import ./make-test-python.nix ({ lib, ... }: { # Check the key hash before and after adding an alias. It should not change. # The previous test reverts the ed384 change webserver.wait_for_unit("acme-finished-a.example.test.target") - keyhash_old = webserver.succeed("md5sum /var/lib/acme/a.example.test/key.pem") switch_to(webserver, "nginx-aliases") webserver.wait_for_unit("acme-finished-a.example.test.target") check_issuer(webserver, "a.example.test", "pebble") check_connection(client, "a.example.test") check_connection(client, "b.example.test") - keyhash_new = webserver.succeed("md5sum /var/lib/acme/a.example.test/key.pem") - assert keyhash_old == keyhash_new with subtest("Can request certificates for vhost + aliases (apache-httpd)"): try: