From 4c10d404e7f3d68fb818b6dddc98b162b0d00832 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Tue, 26 Apr 2016 09:14:39 +0200 Subject: [PATCH] github PR template: reformulate the sandboxing help It's been reported that when running through nix daemon, sandboxing can't be turned on by passing `--option` (silently ignored), so let's not suggest that way. https://github.com/NixOS/nixpkgs/issues/14866#issuecomment-214619909 --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 324c5f17f7a..d85d9e481f2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,9 @@ ###### Things done -- [ ] Tested using sandboxing (`nix-build --option build-use-sandbox true` or [nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS) +- [ ] Tested using sandboxing + ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, + or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) + on non-NixOS) - Built on platform(s) - [ ] NixOS - [ ] OS X