From 220356309e543f99cd6edc975c2c142877411a27 Mon Sep 17 00:00:00 2001 From: ajs124 Date: Mon, 8 Feb 2021 04:01:52 +0100 Subject: [PATCH 1/2] phpExtensions.xmlrpc: disable on 8.0, as it was unbundeled in that release --- pkgs/top-level/php-packages.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/top-level/php-packages.nix b/pkgs/top-level/php-packages.nix index 932c2a867f0..0e081ad8eb7 100644 --- a/pkgs/top-level/php-packages.nix +++ b/pkgs/top-level/php-packages.nix @@ -508,6 +508,8 @@ lib.makeScope pkgs.newScope (self: with self; { ++ lib.optional (lib.versionOlder php.version "7.4") [ "--with-libxml-dir=${libxml2.dev}" ]; } { name = "xmlrpc"; buildInputs = [ libxml2 libiconv ]; + # xmlrpc was unbundled in 8.0 https://php.watch/versions/8.0/xmlrpc + enable = lib.versionOlder php.version "8.0"; configureFlags = [ "--with-xmlrpc" ] # Required to build on darwin. ++ lib.optional (lib.versionOlder php.version "7.4") [ "--with-libxml-dir=${libxml2.dev}" ]; } From b8c532e0615b492daaacdbc192292af124dc1a96 Mon Sep 17 00:00:00 2001 From: ajs124 Date: Mon, 8 Feb 2021 04:05:50 +0100 Subject: [PATCH 2/2] phpExtensions.xsl: fix build against php80 by disabling tests they succeed on 7.3 and 7.4, but not 8.0 --- pkgs/top-level/php-packages.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/top-level/php-packages.nix b/pkgs/top-level/php-packages.nix index 0e081ad8eb7..82cf6cc768e 100644 --- a/pkgs/top-level/php-packages.nix +++ b/pkgs/top-level/php-packages.nix @@ -520,7 +520,7 @@ lib.makeScope pkgs.newScope (self: with self; { ++ lib.optional (lib.versionOlder php.version "7.4") [ "--with-libxml-dir=${libxml2.dev}" ]; } { name = "xsl"; buildInputs = [ libxslt libxml2 ]; - doCheck = !(lib.versionOlder php.version "7.4"); + doCheck = lib.versionOlder php.version "8.0"; configureFlags = [ "--with-xsl=${libxslt.dev}" ]; } { name = "zend_test"; } { name = "zip";